[PATCH] D12095: propagate fast-math-flags on DAG nodes

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 17:30:52 PDT 2015


spatel added a comment.

In http://reviews.llvm.org/D12095#246653, @nlewycky wrote:

> I just noticed that I'm listed as a reviewer here. I'm not familiar enough
>  with this are of llvm to review this patch. Do you need me to patch it in
>  and try it out?


Thank you for the offer, Nick. I'm not expecting any correctness bugs to manifest with this patch. I think there are just potential perf differences resulting from failure to CSE nodes. If your test setup can detect asm or perf diffs, then certainly, I would welcome more testing.

Escha, if you could try this with your out-of-tree target to verify that it doesn't break anything, that would be great. If not, then I think we'll just push this into trunk and see if anyone can detect any differences.

The patch wasn't too far off last time Hal looked it over, so I hope this is almost ready to go. Hal, any other feedback?


http://reviews.llvm.org/D12095





More information about the llvm-commits mailing list