[PATCH] D12713: Runtime test for poisoning vtable pointer during destruction.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 17:05:39 PDT 2015


eugenis added inline comments.

================
Comment at: test/msan/dtor-vtable-multiple-inheritance.cc:15
@@ +14,3 @@
+// function using vtable.
+// XFAIL: *
+
----------------
nmusgrave wrote:
> eugenis wrote:
> > Remove XFAIL. Is it here because the implementation of vptr poisoning is not committed yet?
> > 
> Executing these functions should crash the test
I don't understand. Are you saying that this functionality will stay broken or incomplete even when the vptr change is landed? If not, there should be no XFAIL. Add "not" to the RUN lines that are expected to crash.



http://reviews.llvm.org/D12713





More information about the llvm-commits mailing list