[PATCH] D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms

[Alexey Samsonov via llvm-commits]

samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of nits


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:984
@@ +983,3 @@
+#elif defined(__powerpc64__)
+// TSAN_PPC64 - not completed
+uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg,
----------------
Please make a comment more reasonable
  // FIXME: properly implement clone for PowerPC

================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:344
@@ -334,2 +343,3 @@
   *addr += ThreadDescriptorSize();
-# elif defined(__mips__) || defined(__aarch64__)
+# elif defined(__mips__) || defined(__aarch64__) \
+  || defined(__powerpc64__)
----------------
Probably you don't need line break here


http://reviews.llvm.org/D12841