[PATCH] D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 14:49:30 PDT 2015


zatrazz added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:272
@@ +271,3 @@
+  if (val)
+    atomic_store(&kThreadDescriptorSize, val, memory_order_relaxed);
+  return val;
----------------
You do not need the 'if' statement, just store as AArch64 does.

================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:73
@@ -73,2 +72,3 @@
+#elif defined(__aarch64__) || defined(__powerpc64__)
 #define PTHREAD_ABI_BASE  "GLIBC_2.17"
 #endif
----------------
This is only valid for ELFv2. BE is GLIBC_2.3.


http://reviews.llvm.org/D12841





More information about the llvm-commits mailing list