[llvm] r247692 - Re-commit r247683: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

[Hans Wennborg via llvm-commits]

Sounds good.

Thanks,
Hans

On Tue, Sep 15, 2015 at 9:20 AM, Daniel Sanders via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> This patch has been reverted on Eric's request but I'll add that to my build for future attempts.
>
> Thanks
> ________________________________________
> From: hwennborg at google.com [hwennborg at google.com] on behalf of Hans Wennborg [hans at chromium.org]
> Sent: 15 September 2015 17:19
> To: Daniel Sanders
> Cc: llvm-commits
> Subject: Re: [llvm] r247692 - Re-commit r247683: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.
>
> Hi Daniel,
>
> I think this breaks when building with the WebAssembly backend enabled
> (cmake with -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly)
>
> For example, from
> http://build.chromium.org/p/chromium.fyi/builders/ClangToTMac%20%28dbg%29/builds/1780/steps/gclient%20runhooks/logs/stdio
>
>  - Hans
>
> On Tue, Sep 15, 2015 at 7:08 AM, Daniel Sanders via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: dsanders
>> Date: Tue Sep 15 09:08:28 2015
>> New Revision: 247692
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=247692&view=rev
>> Log:
>> Re-commit r247683: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.
>>
>> Summary:
>> This is the first patch in the series to migrate Triple's (which are ambiguous)
>> to TargetTuple's (which aren't).
>>
>> For the moment, TargetTuple simply passes all requests to the Triple object it
>> holds. Once it has replaced Triple, it will start to implement the interface in
>> a more suitable way.
>>
>> This change makes some changes to the public C++ API. In particular,
>> InitMCSubtargetInfo(), createMCRelocationInfo(), and createMCSymbolizer()
>> now take TargetTuples instead of Triples. The other public C++ API's have
>> been left as-is for the moment to reduce patch size.
>>
>> This commit also contains a trivial patch to clang to account for the C++ API
>> change. Thanks go to Pavel Labath for fixing LLDB for me.
>>
>> Reviewers: rengolin
>>
>> Subscribers: jyknight, dschuff, arsenm, rampitec, danalbert, srhines, javed.absar, dsanders, echristo, emaste, jholewinski, tberghammer, ted, jfb, llvm-commits, rengolin
>>
>> Differential Revision: http://reviews.llvm.org/D10969
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits