[PATCH] D12709: [PATCH] [sanitizers] [msan] Enable MSAN for aarch64

[Renato Golin via llvm-commits]

rengolin added a comment.

One comment inline, another here:

Could you add a comment to the XFAILs stating very briefly what's wrong with it? I'd like to know what's an error you think you can fix it versus one that cannot be implemented due to hardware / architecture restrictions. Even if they all fall into temporary errors, would be good to know what exactly is breaking, to make it easier for people to pick them up and fix them, or even if some unrelated patch does fix them, they can know it's not unrelated after all.

I guess about Darwin names, we shall see if it breaks the Darwin bots.

cheers,
--renato


================
Comment at: test/msan/strlen_of_shadow.cc:31
@@ +30,3 @@
+  if (vma == 39)
+    return (char *)(LINEARIZE_MEM_39(p) + 0x4000000000ULL);
+  else if (vma == 42)
----------------
Can't you just use the macro for now?


http://reviews.llvm.org/D12709