[lld] r247685 - Make this test a bit more robust in preparation to adding more cases.

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 06:30:08 PDT 2015


Author: rafael
Date: Tue Sep 15 08:30:08 2015
New Revision: 247685

URL: http://llvm.org/viewvc/llvm-project?rev=247685&view=rev
Log:
Make this test a bit more robust in preparation to adding more cases.

The first test (call) is now the only test to use .text, which makes it
resistant to more tests being added.

llvm-objdump -d already prints the addresses of symbols. We can use that in the
tests.

Modified:
    lld/trunk/test/elf2/relocation.s

Modified: lld/trunk/test/elf2/relocation.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf2/relocation.s?rev=247685&r1=247684&r2=247685&view=diff
==============================================================================
--- lld/trunk/test/elf2/relocation.s (original)
+++ lld/trunk/test/elf2/relocation.s Tue Sep 15 08:30:08 2015
@@ -1,6 +1,6 @@
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
 // RUN: lld -flavor gnu2 %t -o %t2
-// RUN: llvm-objdump -t -d %t2 | FileCheck %s
+// RUN: llvm-objdump -d %t2 | FileCheck %s
 // REQUIRES: x86
 
 
@@ -13,17 +13,24 @@ _start:
 .zero 4
 .global lulz
 lulz:
+  nop
+
+// CHECK: Disassembly of section .text:
+// CHECK-NEXT: _start:
+// CHECK-NEXT:   11000:  e8 04 00 00 00   callq 4
+// CHECK-NEXT:   11005:
+
+// CHECK:      lulz:
+// CHECK-NEXT:   11009:  90  nop
+
 
 .global bar
-.text
+.section       .text2,"ax", at progbits
 bar:
   movl $bar, %edx // R_X86_64_32
 
-// R_X86_64_32
-// CHECK: bar:
-// CHECK:  11000: ba 00 10 01 00 movl $69632, %edx
-
-// CHECK: e8 04 00 00 00  callq   4
-
-// Also check that symbols match.
-// CHECK: 0000000000011000         .text           00000000 bar
+// FIXME: this would be far more self evident if llvm-objdump printed
+// constants in hex.
+// CHECK: Disassembly of section .text2:
+// CHECK-NEXT: bar:
+// CHECK-NEXT:  12000: {{.*}} movl $73728, %edx




More information about the llvm-commits mailing list