[llvm] r247450 - Use function attribute "stackrealign" to decide whether stack

[Akira Hatanaka via llvm-commits]

On Sat, Sep 12, 2015 at 7:42 AM, Joerg Sonnenberger via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Fri, Sep 11, 2015 at 12:57:38PM -0700, Reid Kleckner wrote:
> > On Fri, Sep 11, 2015 at 12:40 PM, Joerg Sonnenberger via llvm-commits <
> > llvm-commits at lists.llvm.org> wrote:
> >
> > > On Fri, Sep 11, 2015 at 06:54:39PM -0000, Akira Hatanaka via
> llvm-commits
> > > wrote:
> > > > URL: http://llvm.org/viewvc/llvm-project?rev=247450&view=rev
> > > > Log:
> > > > Use function attribute "stackrealign" to decide whether stack
> > > > realignment should be forced.
> > >
> > > Can you please actually call it force_stackrealign or
> > > always_realign_stack to avoid confusion?
> > >
> >
> > The X86 backend looks for a "no-stack-realign" attribute. Perhaps we
> should
> > have a string attribute "stackrealign" with three values, "always",
> "auto",
> > and "never". The default behavior is "auto".
>
> That also seems to be reasonable.
>
>
Some users might need "no-stack-realign", so I'll hold off on converting it
to a cl::opt option.

Using "stackrealign" with three values sounds like a good idea. However,
since "no-stack-realign" has been around for a while, I feel a little
hesitant to replace it with "stackrealign"="never". I didn't think
"stackrealign" would confuse people, but I can replace "stackrealign" with
something like "force-align-stack" or "always-align-stack" if that's
desirable.



> Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150914/dba72f6a/attachment.html>