[PATCH] D12867: ELF2: Simplify by removing temporary variables

[Rui Ueyama via llvm-commits]

That's really good point, we probably should use ulittle32_t instead.
Regarding alignment, don't we guarantee that the in-memory object we are
building aligned properly?

On Mon, Sep 14, 2015 at 5:34 PM, Rafael Ávila de Espíndola <
rafael.espindola at gmail.com> wrote:

> rafael accepted this revision.
> rafael added a comment.
> This revision is now accepted and ready to land.
>
> LGTM.
>
> The new version is writing directly to mmaped memory.  It is also using a
> type that in unaligned and may have non-native endian.
>
> But this is code that will likely be revisited once we can link something
> large enough to benchmark, so yes, lets keep the simpler version for now.
>
>
> http://reviews.llvm.org/D12867
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150914/6a59c468/attachment.html>