[PATCH] D12837: [Polly] Revise polly-{update|check}-format targets

[Tobias Grosser via llvm-commits]

On 09/14/2015 07:40 PM, Michael Kruse wrote:
> Meinersbur added a comment.
>
> In http://reviews.llvm.org/D12837#245328, @jdoerfert wrote:
>
>>> Meinersbur added a comment.
>>
>>>
>>
>>> In http://reviews.llvm.org/D12837#245090, @grosser wrote:
>>
>>>
>>
>>>> Looking at this, it would also be great if we would call polly-check-format from check-polly, if clang-format is available in our build (and we are not just a LLVM+Polly build).
>>
>>>
>>
>>> In another commit.
>>
>>>
>>
>>> I personally think this would be exaggerated.  Some white space in the source has no influence on the correctness of build product. Also, LLVM doesn't do this either.

Sure, the single whitespace does matter so much. But at least in my experience,
having a format-clean Polly has saves a lot of time in patch/review discussions
and also avoids this annoying reformat whole file commits we have in LLVM every
couple of days.

>> As long as we break the buildbots with white space errors it makes sense
>>   to break the local unit tests too. I would like such a feature if
>>   possible.
>
>
> You can just run "ninja check-polly polly-check-format".

Yes, unfortunately I forget this every once in a while.
  
> However, here is the patch: http://reviews.llvm.org/D12850

Great. LGTM, btw.

Tobias