[PATCH] D12837: [Polly] Revise polly-{update|check}-format targets

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 10:30:52 PDT 2015


jdoerfert added a subscriber: jdoerfert.
jdoerfert added a comment.

> Meinersbur added a comment.

> 

> In http://reviews.llvm.org/D12837#245090, @grosser wrote:

> 

> > Looking at this, it would also be great if we would call polly-check-format from check-polly, if clang-format is available in our build (and we are not just a LLVM+Polly build).

> 

> In another commit.

> 

> I personally think this would be exaggerated.  Some white space in the source has no influence on the correctness of build product. Also, LLVM doesn't do this either.


As long as we break the buildbots with white space errors it makes sense
to break the local unit tests too. I would like such a feature if
possible.

- F831164: msg-22803-76.dat <http://reviews.llvm.org/F831164>


Repository:
  rL LLVM

http://reviews.llvm.org/D12837





More information about the llvm-commits mailing list