[PATCH] D12824: [x86][WIP] CSR alignment, dead code?

[Philip Reames via llvm-commits]

reames added a comment.

In http://reviews.llvm.org/D12824#244770, @ahatanak wrote:

> MachineFrameInfo::ensureMaxAlignment(unsigned Align) updates MaxAlignment so that it is as least as large as Align. When you say "the line in question has no effect", does that mean MaxAlignment never gets updated or MaxAlignment never gets used after line 1346?


Ok, it looks like I was wrong here.  I'd misread the code; most of the CreateX functions on MFI call ensureMaxAlignment, CreateFixedSplilStackObject does not.  I had thought line was redundant, but I was wrong. So, that invalidates the actual patch.

However, can you possibly explain *why* we're setting the max alignment even when we can't actually realign the stack?  That seems odd to say the least.


http://reviews.llvm.org/D12824