[llvm] r247518 - [llvm-mc] More meaningful error if input file doesn't exist.

[Davide Italiano via llvm-commits]

http://reviews.llvm.org/D12846

On Sun, Sep 13, 2015 at 11:45 AM, Davide Italiano <davide at freebsd.org> wrote:
> On Sun, Sep 13, 2015 at 11:08 AM, Davide Italiano <davide at freebsd.org> wrote:
>> On Sun, Sep 13, 2015 at 4:43 AM, Rafael Espíndola
>> <rafael.espindola at gmail.com> wrote:
>>> testcase?
>>>
>>
>> Will add one.
>>
>>> Can't this be done by testing the value of EC down at
>>> BufferPtr.getError() instead of calling sys::fs::exists?
>>>
>>> Cheers,
>>> Rafael
>>>
>>
>> Probably it could. I was just mimicing what was already there (e.g. llvm-size).
>> I will do a sweep over all tools needing this and send out a review,
>> it's arguably better.
>>
>
> hmm, this turned out to be slightly more annoying than I expected.
> It seems we have a very non-uniform error handling among tools for the
> same error, so for now I'll just fixup this one and think about others
> at a later time.
>
> --
> Davide



-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare