[lld] r247531 - COFF: Corrected error message if a section failed to load.

[Rui Ueyama via llvm-commits]

Author: ruiu
Date: Sun Sep 13 15:22:22 2015
New Revision: 247531

URL: http://llvm.org/viewvc/llvm-project?rev=247531&view=rev
Log:
COFF: Corrected error message if a section failed to load.

There is no sense to use Name in these lines as it is not initialized yet.

Patch from Igor Kudrin!

Added:
    lld/trunk/test/COFF/invalid-obj.test
Modified:
    lld/trunk/COFF/InputFiles.cpp

Modified: lld/trunk/COFF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/InputFiles.cpp?rev=247531&r1=247530&r2=247531&view=diff
==============================================================================
--- lld/trunk/COFF/InputFiles.cpp (original)
+++ lld/trunk/COFF/InputFiles.cpp Sun Sep 13 15:22:22 2015
@@ -115,9 +115,9 @@ void ObjectFile::initializeChunks() {
     const coff_section *Sec;
     StringRef Name;
     std::error_code EC = COFFObj->getSection(I, Sec);
-    error(EC, Twine("getSection failed: ") + Name);
+    error(EC, Twine("getSection failed: #") + Twine(I));
     EC = COFFObj->getSectionName(Sec, Name);
-    error(EC, Twine("getSectionName failed: ") + Name);
+    error(EC, Twine("getSectionName failed: #") + Twine(I));
     if (Name == ".sxdata") {
       SXData = Sec;
       continue;

Added: lld/trunk/test/COFF/invalid-obj.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/invalid-obj.test?rev=247531&view=auto
==============================================================================
--- lld/trunk/test/COFF/invalid-obj.test (added)
+++ lld/trunk/test/COFF/invalid-obj.test Sun Sep 13 15:22:22 2015
@@ -0,0 +1,14 @@
+# RUN: yaml2obj %s > %t.obj
+# RUN: not lld-link %t.obj 2>&1 | FileCheck %s
+
+# CHECK: getSectionName failed: #1:
+
+---
+header:
+  Machine:         IMAGE_FILE_MACHINE_AMD64
+  Characteristics: []
+sections:
+  - Name:            '/1'
+    Characteristics: []
+    SectionData:     00
+symbols: