[PATCH] D12829: [LLD] Corrected error message if a section failed to load

Igor Kudrin via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 12 08:50:39 PDT 2015


ikudrin created this revision.
ikudrin added reviewers: rafael, ruiu.
ikudrin added a subscriber: llvm-commits.
ikudrin added a project: lld.

There is no sense to use Name in these lines as it is not initialized yet.

http://reviews.llvm.org/D12829

Files:
  lld/trunk/COFF/InputFiles.cpp

Index: lld/trunk/COFF/InputFiles.cpp
===================================================================
--- lld/trunk/COFF/InputFiles.cpp
+++ lld/trunk/COFF/InputFiles.cpp
@@ -115,9 +115,9 @@
     const coff_section *Sec;
     StringRef Name;
     std::error_code EC = COFFObj->getSection(I, Sec);
-    error(EC, Twine("getSection failed: ") + Name);
+    error(EC, Twine("getSection failed: #") + Twine(I));
     EC = COFFObj->getSectionName(Sec, Name);
-    error(EC, Twine("getSectionName failed: ") + Name);
+    error(EC, Twine("getSectionName failed: #") + Twine(I));
     if (Name == ".sxdata") {
       SXData = Sec;
       continue;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12829.34628.patch
Type: text/x-patch
Size: 643 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150912/635dbf59/attachment.bin>


More information about the llvm-commits mailing list