[llvm] r247450 - Use function attribute "stackrealign" to decide whether stack

Joerg Sonnenberger via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 12 07:42:28 PDT 2015


On Fri, Sep 11, 2015 at 12:57:38PM -0700, Reid Kleckner wrote:
> On Fri, Sep 11, 2015 at 12:40 PM, Joerg Sonnenberger via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
> 
> > On Fri, Sep 11, 2015 at 06:54:39PM -0000, Akira Hatanaka via llvm-commits
> > wrote:
> > > URL: http://llvm.org/viewvc/llvm-project?rev=247450&view=rev
> > > Log:
> > > Use function attribute "stackrealign" to decide whether stack
> > > realignment should be forced.
> >
> > Can you please actually call it force_stackrealign or
> > always_realign_stack to avoid confusion?
> >
> 
> The X86 backend looks for a "no-stack-realign" attribute. Perhaps we should
> have a string attribute "stackrealign" with three values, "always", "auto",
> and "never". The default behavior is "auto".

That also seems to be reasonable.

Joerg


More information about the llvm-commits mailing list