[PATCH] D12773: [PM] Port SROA to the new pass manager.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 19:07:39 PDT 2015


Thanks for the feeback!

On Fri, Sep 11, 2015 at 11:47 AM Justin Bogner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> A couple of minor comments below, then as long as nobody's opposed to
> this path it LGTM.
>

Comments addressed, but there is one outstanding question I'd like a better
answer to before I move forward: how to name the legacy pass manager passes.

I don't actually have strong feelings here. Here is the current reasoning I
see, which doesn't leave a clear choice IMO:

- FooWrapperPass is a legacy PM wrapper around the Foo analysis results
- FooLegacyPass is a legacy PM pass for the Foo transformation

Meh. Thoughts?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150912/953a0b1b/attachment.html>


More information about the llvm-commits mailing list