[PATCH] D12779: [InstCombineCalls] Use isKnownNonNullAt() to check nullness of passing arguments at callsite

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 15:56:43 PDT 2015


reames added a comment.

Revised version w/fix LGTM provided test case added.

I'm a bit concerned that we'll see the assert you added trip in something which doesn't have a unit test, but if we do, the fix should be pretty obvious at the call site.  Please call this out specifically in the commit message.


http://reviews.llvm.org/D12779





More information about the llvm-commits mailing list