[PATCH] D12790: ubsan: Implement memory permission validation for vtables.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.

================
Comment at: lib/ubsan/ubsan_type_hash_itanium.cc:199
@@ +198,3 @@
+
+#if SANITIZER_LINUX
+  // Validate the memory permissions of the vtable pointer and the first
----------------
kcc wrote:
> ifdefs inside the function body is a great evil. 
> 
> Alternatively, or maybe even much better, I'd ask you to move this functionality into a separate function
> somewhere in sanitizer_common.
This code isn't really general purpose enough to live in sanitizer_common. I've moved it into a separate function in this file.


http://reviews.llvm.org/D12790