[llvm] r247471 - [MC] Don't crash on division by zero.
Rafael EspĂndola via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 11 14:23:12 PDT 2015
> + case MCBinaryExpr::Div: {
> + // Handle division by zero. gas just emits a warning and keeps going,
> + // we try to be stricter.
> + // FIXME: Currently the caller of this function has no way to understand
> + // we're bailing out because of 'division by zero'. Therefore, it will
> + // emit a 'expected relocatable expression' error. It would be nice to
> + // change this code to emit a better diagnostic.
> + if (RHS == 0)
> + return false;
> + Result = LHS / RHS; break;
> + }
You don't need the {}
The break should be on the next line.
Cheers,
Rafael
More information about the llvm-commits
mailing list