[PATCH] D12660: Make the default triple optional by allowing an empty string

[Paul Robinson via llvm-commits]

probinson added a comment.

+echristo as debug-info owner, to judge whether moving the top-level DebugInfo tests to a Generic subdirectory is okay.

Two minor comment suggestions, everything else LGTM.


================
Comment at: test/lit.cfg:344
@@ +343,3 @@
+# LLVM can be configured with an empty default triple
+# Some tests are "generic" and require a valid default triple
+if config.target_triple:
----------------
Comments should end with a period.

================
Comment at: test/lit.cfg:346
@@ +345,3 @@
+if config.target_triple:
+    config.available_features.add("default_triple")
+
----------------
I think the name is descriptive, just an example of how it's used would help clarify things.


http://reviews.llvm.org/D12660