[PATCH] D12790: ubsan: Implement memory permission validation for vtables.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 10:18:06 PDT 2015


kcc added inline comments.

================
Comment at: lib/ubsan/ubsan_type_hash_itanium.cc:199
@@ +198,3 @@
+
+#if SANITIZER_LINUX
+  // Validate the memory permissions of the vtable pointer and the first
----------------
ifdefs inside the function body is a great evil. 

Alternatively, or maybe even much better, I'd ask you to move this functionality into a separate function
somewhere in sanitizer_common.


http://reviews.llvm.org/D12790





More information about the llvm-commits mailing list