[PATCH] D12715: Reduce PGO Instrumentation binary and profile data size (Patch-1)

[Than McIntosh via llvm-commits]

thanm added a comment.

I see a some new  warnings when I build the code (after "arc patch http://reviews.llvm.org/D12715"):

[35/42] Building CXX object tools/clan...s/clangCodeGen.dir/CodeGenModule.cpp.o
In file included from /ssd/llvm-trunk-profinst/llvm/tools/clang/lib/CodeGen/CodeGenModule.cpp:53:
In file included from /ssd/llvm-trunk-profinst/llvm/include/llvm/ProfileData/InstrProfReader.h:20:
/ssd/llvm-trunk-profinst/llvm/include/llvm/ProfileData/InstrProf.h:111:10: warning: unused function 'getMagic' [-Wunused-function]
uint64_t getMagic<uint64_t>() {

  ^

/ssd/llvm-trunk-profinst/llvm/include/llvm/ProfileData/InstrProf.h:124:10: warning: unused function 'getMagic' [-Wunused-function]
uint64_t getMagic<uint32_t>() {

  ^


================
Comment at: include/llvm/ProfileData/InstrProf.h:59
@@ +58,3 @@
+
+/// A helper function to extract the fromat version value from the version
+/// field. The feature bits are filtered out.
----------------
typo fromat -> format

================
Comment at: include/llvm/Transforms/Instrumentation.h:87
@@ -86,1 +86,3 @@
 
+  // Include full funciton names in profile.
+  bool IncludeNamesInProfile;
----------------
typo funciton => function


http://reviews.llvm.org/D12715