[PATCH] D12763: [PATCH] [compiler-rt] [sanitizers] Add VMA size check at runtime

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 10:02:40 PDT 2015


rengolin added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_posix.cc:336
@@ +335,3 @@
+    Printf("WARNING: Runtime VMA is not the one built for.\n");
+    Printf("\tBuilt VMA:   %p\n", maxBuiltVirtualSize);
+    Printf("\tRuntime VMA: %p\n", maxRuntimeVirtualSize);
----------------
zatrazz wrote:
> rengolin wrote:
> > I was expecting this to print things like 39/42, not the max size.
> I tried to be less intrusive as possible, since only GetMaxVirtualAddress is really defined in a multiplatform way. However if the idea is to show 39/42 I think we can create a symbol to return it as well.
I think the max size will be very uninformative. Maybe it would be good to have that CLZ function in the sanitizers after all.


http://reviews.llvm.org/D12763





More information about the llvm-commits mailing list