[PATCH] D11885: AMDGPU/SI: Add SI Machine Scheduler

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 08:31:05 PDT 2015


tstellarAMD added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:134-135
@@ -123,2 +133,4 @@
       return createR600MachineScheduler(C);
+    //else //(uncomment to turn default for SI)
+    //  return createSIMachineScheduler(C);
     return nullptr;
----------------
Ok.  We'll need to remove these commented lines before the patch is committed.

================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.h:173-174
@@ +172,4 @@
+
+enum SISchedulerBlockCreatorVariant {
+    LatenciesAlone};
+
----------------
Coding style, }; should be on new line.


http://reviews.llvm.org/D11885





More information about the llvm-commits mailing list