[llvm] r247245 - [ADT] Switch a bunch of places in LLVM that were doing single-character
Chandler Carruth via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 9 23:12:31 PDT 2015
Author: chandlerc
Date: Thu Sep 10 01:12:31 2015
New Revision: 247245
URL: http://llvm.org/viewvc/llvm-project?rev=247245&view=rev
Log:
[ADT] Switch a bunch of places in LLVM that were doing single-character
splits to actually use the single character split routine which does
less work, and in a debug build is *substantially* faster.
Modified:
llvm/trunk/lib/MC/MCSectionMachO.cpp
llvm/trunk/lib/MC/SubtargetFeature.cpp
llvm/trunk/lib/Support/GraphWriter.cpp
llvm/trunk/lib/Support/Host.cpp
llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp
llvm/trunk/lib/Target/NVPTX/NVVMReflect.cpp
llvm/trunk/lib/Target/SystemZ/SystemZTargetMachine.cpp
llvm/trunk/unittests/Support/Path.cpp
Modified: llvm/trunk/lib/MC/MCSectionMachO.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSectionMachO.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCSectionMachO.cpp (original)
+++ llvm/trunk/lib/MC/MCSectionMachO.cpp Thu Sep 10 01:12:31 2015
@@ -177,7 +177,7 @@ std::string MCSectionMachO::ParseSection
TAAParsed = false;
SmallVector<StringRef, 5> SplitSpec;
- Spec.split(SplitSpec, ",");
+ Spec.split(SplitSpec, ',');
// Remove leading and trailing whitespace.
auto GetEmptyOrTrim = [&SplitSpec](size_t Idx) -> StringRef {
return SplitSpec.size() > Idx ? SplitSpec[Idx].trim() : StringRef();
@@ -235,7 +235,7 @@ std::string MCSectionMachO::ParseSection
// The attribute list is a '+' separated list of attributes.
SmallVector<StringRef, 1> SectionAttrs;
- Attrs.split(SectionAttrs, "+", /*MaxSplit=*/-1, /*KeepEmpty=*/false);
+ Attrs.split(SectionAttrs, '+', /*MaxSplit=*/-1, /*KeepEmpty=*/false);
for (StringRef &SectionAttr : SectionAttrs) {
auto AttrDescriptorI = std::find_if(
Modified: llvm/trunk/lib/MC/SubtargetFeature.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/SubtargetFeature.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/lib/MC/SubtargetFeature.cpp (original)
+++ llvm/trunk/lib/MC/SubtargetFeature.cpp Thu Sep 10 01:12:31 2015
@@ -56,7 +56,7 @@ static inline bool isEnabled(StringRef F
///
static void Split(std::vector<std::string> &V, StringRef S) {
SmallVector<StringRef, 3> Tmp;
- S.split(Tmp, ",", -1, false /* KeepEmpty */);
+ S.split(Tmp, ',', -1, false /* KeepEmpty */);
V.assign(Tmp.begin(), Tmp.end());
}
Modified: llvm/trunk/lib/Support/GraphWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/GraphWriter.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/lib/Support/GraphWriter.cpp (original)
+++ llvm/trunk/lib/Support/GraphWriter.cpp Thu Sep 10 01:12:31 2015
@@ -103,7 +103,7 @@ struct GraphSession {
bool TryFindProgram(StringRef Names, std::string &ProgramPath) {
raw_string_ostream Log(LogBuffer);
SmallVector<StringRef, 8> parts;
- Names.split(parts, "|");
+ Names.split(parts, '|');
for (auto Name : parts) {
if (ErrorOr<std::string> P = sys::findProgramByName(Name)) {
ProgramPath = *P;
Modified: llvm/trunk/lib/Support/Host.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Host.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/lib/Support/Host.cpp (original)
+++ llvm/trunk/lib/Support/Host.cpp Thu Sep 10 01:12:31 2015
@@ -697,7 +697,7 @@ StringRef sys::getHostCPUName() {
if (Lines[I].startswith("features")) {
size_t Pos = Lines[I].find(":");
if (Pos != StringRef::npos) {
- Lines[I].drop_front(Pos + 1).split(CPUFeatures, " ");
+ Lines[I].drop_front(Pos + 1).split(CPUFeatures, ' ');
break;
}
}
@@ -840,7 +840,7 @@ bool sys::getHostCPUFeatures(StringMap<b
// Look for the CPU features.
for (unsigned I = 0, E = Lines.size(); I != E; ++I)
if (Lines[I].startswith("Features")) {
- Lines[I].split(CPUFeatures, " ");
+ Lines[I].split(CPUFeatures, ' ');
break;
}
Modified: llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp Thu Sep 10 01:12:31 2015
@@ -2283,7 +2283,7 @@ AArch64DAGToDAGISel::SelectCVTFixedPosOp
// into a single value to be used in the MRS/MSR instruction.
static int getIntOperandFromRegisterString(StringRef RegString) {
SmallVector<StringRef, 5> Fields;
- RegString.split(Fields, ":");
+ RegString.split(Fields, ':');
if (Fields.size() == 1)
return -1;
Modified: llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp Thu Sep 10 01:12:31 2015
@@ -3265,7 +3265,7 @@ static void getIntOperandsFromRegisterSt
SelectionDAG *CurDAG, SDLoc DL,
std::vector<SDValue>& Ops) {
SmallVector<StringRef, 5> Fields;
- RegString.split(Fields, ":");
+ RegString.split(Fields, ':');
if (Fields.size() > 1) {
bool AllIntFields = true;
@@ -3631,7 +3631,7 @@ SDNode *ARMDAGToDAGISel::SelectWriteRegi
}
SmallVector<StringRef, 5> Fields;
- StringRef(SpecialReg).split(Fields, "_", 1, false);
+ StringRef(SpecialReg).split(Fields, '_', 1, false);
std::string Reg = Fields[0].str();
StringRef Flags = Fields.size() == 2 ? Fields[1] : "";
Modified: llvm/trunk/lib/Target/NVPTX/NVVMReflect.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/NVPTX/NVVMReflect.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/lib/Target/NVPTX/NVVMReflect.cpp (original)
+++ llvm/trunk/lib/Target/NVPTX/NVVMReflect.cpp Thu Sep 10 01:12:31 2015
@@ -109,10 +109,10 @@ void NVVMReflect::setVarMap() {
for (unsigned i = 0, e = ReflectList.size(); i != e; ++i) {
DEBUG(dbgs() << "Option : " << ReflectList[i] << "\n");
SmallVector<StringRef, 4> NameValList;
- StringRef(ReflectList[i]).split(NameValList, ",");
+ StringRef(ReflectList[i]).split(NameValList, ',');
for (unsigned j = 0, ej = NameValList.size(); j != ej; ++j) {
SmallVector<StringRef, 2> NameValPair;
- NameValList[j].split(NameValPair, "=");
+ NameValList[j].split(NameValPair, '=');
assert(NameValPair.size() == 2 && "name=val expected");
std::stringstream ValStream(NameValPair[1]);
int Val;
Modified: llvm/trunk/lib/Target/SystemZ/SystemZTargetMachine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/SystemZ/SystemZTargetMachine.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/lib/Target/SystemZ/SystemZTargetMachine.cpp (original)
+++ llvm/trunk/lib/Target/SystemZ/SystemZTargetMachine.cpp Thu Sep 10 01:12:31 2015
@@ -32,7 +32,7 @@ static bool UsesVectorABI(StringRef CPU,
VectorABI = false;
SmallVector<StringRef, 3> Features;
- FS.split(Features, ",", -1, false /* KeepEmpty */);
+ FS.split(Features, ',', -1, false /* KeepEmpty */);
for (auto &Feature : Features) {
if (Feature == "vector" || Feature == "+vector")
VectorABI = true;
Modified: llvm/trunk/unittests/Support/Path.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/Path.cpp?rev=247245&r1=247244&r2=247245&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/Path.cpp (original)
+++ llvm/trunk/unittests/Support/Path.cpp Thu Sep 10 01:12:31 2015
@@ -158,7 +158,7 @@ TEST(Support, RelativePathIterator) {
PathComponents ExpectedPathComponents;
PathComponents ActualPathComponents;
- StringRef(Path).split(ExpectedPathComponents, "/");
+ StringRef(Path).split(ExpectedPathComponents, '/');
for (path::const_iterator I = path::begin(Path), E = path::end(Path); I != E;
++I) {
@@ -178,7 +178,7 @@ TEST(Support, RelativePathDotIterator) {
PathComponents ExpectedPathComponents;
PathComponents ActualPathComponents;
- StringRef(Path).split(ExpectedPathComponents, "/");
+ StringRef(Path).split(ExpectedPathComponents, '/');
for (path::const_iterator I = path::begin(Path), E = path::end(Path); I != E;
++I) {
@@ -198,7 +198,7 @@ TEST(Support, AbsolutePathIterator) {
PathComponents ExpectedPathComponents;
PathComponents ActualPathComponents;
- StringRef(Path).split(ExpectedPathComponents, "/");
+ StringRef(Path).split(ExpectedPathComponents, '/');
// The root path will also be a component when iterating
ExpectedPathComponents[0] = "/";
@@ -221,7 +221,7 @@ TEST(Support, AbsolutePathDotIterator) {
PathComponents ExpectedPathComponents;
PathComponents ActualPathComponents;
- StringRef(Path).split(ExpectedPathComponents, "/");
+ StringRef(Path).split(ExpectedPathComponents, '/');
// The root path will also be a component when iterating
ExpectedPathComponents[0] = "/";
More information about the llvm-commits
mailing list