[PATCH] D12740: [LLVM] Fix Clang-tidy misc-use-override warnings, other minor fixes
Hans Wennborg via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 9 17:13:13 PDT 2015
hans added a reviewer: llvm-commits.
hans added a comment.
Please keep the list cc'd on patches.
I have a few 80-column nits, but can fix those when committing.
For future patches, please generate the patch with more context (e.g. "git diff -U9999"); that way the context is available in Phabricator.
================
Comment at: include/llvm/ExecutionEngine/RuntimeDyld.h:72
@@ -71,3 +71,3 @@
- uint64_t getSectionLoadAddress(const object::SectionRef &Sec) const;
+ uint64_t getSectionLoadAddress(const object::SectionRef &Sec) const override;
----------------
80 cols
================
Comment at: lib/ExecutionEngine/MCJIT/MCJIT.h:231
@@ -230,3 +230,3 @@
/// general code.
- virtual GlobalVariable *FindGlobalVariableNamed(const char *Name, bool AllowInternal = false) override;
+ GlobalVariable *FindGlobalVariableNamed(const char *Name, bool AllowInternal = false) override;
----------------
This line was 80+ columns before, but we might as well fix it while here.
Repository:
rL LLVM
http://reviews.llvm.org/D12740
More information about the llvm-commits
mailing list