[PATCH] D10969: Replace Triple with a new TargetTuple in MCTargetDesc/* and related. NFC.

[Renato Golin via llvm-commits]

rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.

Hi Daniel,

For what it is, the patch looks good to me.

It's a big mechanical patch that implements a Tuple wrapper to Triple and change all places that used to use Triples. I don't expect it to clean up anything, since for now we're just moving things alone, but would be good to make Triple use the Tuple enums before deprecating it, so that you can remove a lot of code inserted by this patch.

If people feel uncomfortable with so much being added spuriously, maybe you could have a go at doing that change now. But I don't think it's strictly necessary and will leave at your discretion. We need to move this thing forward as it has taken too long and too much of the ARM and MIPS architectural support depends on this.

Not that this could change anything anywhere else, but It'd be good to have other back-end owners to agree, since this is a big change. I believe most people are copied in this review, anyway, and had time enough to care.


http://reviews.llvm.org/D10969