[PATCH] D12499: [WIP] Replace ScalarEvolution based domain generation

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Johannes,

some smaller comments only:


================
Comment at: lib/Analysis/ScopDetection.cpp:351
@@ +350,3 @@
+    if (ICmp->getOperand(0)->getType()->isPointerTy())
+      return false;
+
----------------
Can you please commit this separately.

================
Comment at: lib/Analysis/ScopInfo.cpp:1
@@ -1,2 +1,2 @@
-//===--------- ScopInfo.cpp  - Create Scops from LLVM IR ------------------===//
+
 //
----------------
You drop the header comment here accidentally.

================
Comment at: lib/Support/SCEVValidator.cpp:357
@@ +356,3 @@
+    return ValidatorResult(SCEVType::INVALID);
+    /*
+        assert(SRem->getOpcode() == Instruction::SRem &&
----------------
Interesting. I do not care so much about loop bounds/conditions, but it would be sad to loose support even in array index expressions. To my understanding, srem instructions in index expressions should not cause troubles in our domain generation algorithm, no?


http://reviews.llvm.org/D12499