[PATCH] D11802: AVX512 : vextracti64x2 implemantation

[Elena Demikhovsky via llvm-commits]

delena added a comment.

Some comments are missing. You can add them and commit the code.
Thanks


================
Comment at: lib/Target/X86/X86InstrAVX512.td:578
@@ +577,3 @@
+
+multiclass vextract_for_size_no_alt<int Opcode,
+                                    X86VectorVTInfo From, X86VectorVTInfo To,
----------------
Please add a comment about no_alt and alt forms.

================
Comment at: lib/Target/X86/X86InstrAVX512.td:584
@@ -574,2 +583,3 @@
   let hasSideEffects = 0, ExeDomain = To.ExeDomain in {
     defm rr : AVX512_maskable_in_asm<Opcode, MRMDestReg, To, (outs To.RC:$dst),
+                (ins From.RC:$src1, i32u8imm:$idx),
----------------
Please add a comment here explaining why do you use the "maskable_in_asm" form.


Repository:
  rL LLVM

http://reviews.llvm.org/D11802