[PATCH] D11678: [CodeGen] Fixes *absdiff* intrinsic: LangRef doc/test case improvement and corresponding code change

[Shahid via llvm-commits]

ashahid added a comment.

Hi Ahmed,

Thanks for the comments. I will do the needful.

Regarding the test merging, IMO, even if it is not useful now, having a place holder as _256.ll is not a bad idea.

Regards,
Shahid


================
Comment at: test/CodeGen/X86/absdiff_256.ll:25-27
@@ +24,5 @@
+; CHECK-NEXT:    pandn %xmm1, %xmm5
+; CHECK-DAG:     psubw %xmm1, %xmm4
+; CHECK-DAG:     pxor %xmm0, %xmm3
+; CHECK:         pandn %xmm4, %xmm3
+; CHECK-NEXT:    por %xmm5, %xmm3
----------------
ab wrote:
> Why do these need CHECK-DAG?
This is for the case where psubw and pxor comes in different order. Doesn't it qualify for CHECK-DAG?


http://reviews.llvm.org/D11678