[PATCH] D12603: Use fixed-point representation for BranchProbability

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 22:56:07 PDT 2015


davidxl added inline comments.

================
Comment at: test/CodeGen/AArch64/aarch64-deferred-spilling.ll:26
@@ -27,1 +25,3 @@
+; REGULAR-NOT: {{[wx]}}21{{,?}}
+; REGUAL: ldr w21, [sp, #[[OFFSET]]] // 4-byte Folded Reload
 ;
----------------
register name change?

================
Comment at: test/CodeGen/ARM/cmpxchg-weak.ll:11
@@ -10,3 +10,3 @@
 ; CHECK:     cmp     [[LOADED]], r1
-; CHECK:     strexeq [[SUCCESS:r[0-9]+]], r2, [r0]
-; CHECK:     cmpeq   [[SUCCESS]], #0
+; CHECK:     strex   [[SUCCESS:r[0-9]+]], r2, [r0]
+; CHECK:     cmp     [[SUCCESS]], #0
----------------
unrelated change?

================
Comment at: test/CodeGen/ARM/cmpxchg-weak.ll:34
@@ -33,4 +33,3 @@
 ; CHECK:      cmp     [[LOADED]], r2
-; CHECK:      strexeq [[STATUS:r[0-9]+]], r3, [r1]
-; CHECK:      cmpeq   [[STATUS]], #0
-; CHECK:      bne     [[DONE:LBB[0-9]+_[0-9]+]]
+; CHECK:      strex   [[STATUS:r[0-9]+]], r3, [r1]
+; CHECK:      cmp     [[STATUS]], #0
----------------
unrelated change?

================
Comment at: test/CodeGen/ARM/ifcvt-branch-weight-bug.ll:26
@@ -26,2 +25,3 @@
+; CHECK: Successors according to CFG: BB#2(130023362) BB#5(62)
 for.body:
   br i1 undef, label %for.cond.backedge, label %lor.lhs.false.i, !prof !1
----------------
bb#4->bb#5 : unrelated change.

================
Comment at: test/CodeGen/ARM/vector-promotion.ll:56
@@ -55,3 +55,3 @@
 ; ASM-LABEL: unsupportedChainInDifferentBBs:
-; ASM: vldrne [[LOAD:d[0-9]+]], [r0]
-; ASM: vmovne.32 {{r[0-9]+}}, [[LOAD]]
+; ASM: vldr [[LOAD:d[0-9]+]], [r0]
+; ASM: vmov.32 {{r[0-9]+}}, [[LOAD]]
----------------
unrelated change


http://reviews.llvm.org/D12603





More information about the llvm-commits mailing list