[PATCH] D12707: [PATCH] [sanitizers] Add MSan support for AArch64

[Evgeniy Stepanov via llvm-commits]

eugenis added a subscriber: eugenis.

================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:125
@@ +124,3 @@
+// AArch64 has 3 VMA sizes: 39, 42 and 48.
+#ifndef SANITIZER_AARCH64_VMA
+# define SANITIZER_AARCH64_VMA 39
----------------
What's that?
It's not even attached to any cmake setting.
Does it mean that a typical clang binary can target all of x86/arm/ppc/etc, 32/64, but only one fixed aarch64 kernel configuration?

I really think this should be a compiler flag.

And it should be possible to remove the corresponding macro in compiler-rt as well by exporting this setting through a global variable in the compiled objects (see __msan_keep_going or the ASAN_FLEXIBLE_MAPPING thing).



http://reviews.llvm.org/D12707