[PATCH] D12679: [CMake] Flag recursive cmake invocations for cross-compile

[Chris Bieneman via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

I think the proper solution for this in the long run would be either for CoreCLR to vend CMake packaging information or for LLILC to provide the package information. There are a number of "Find*.cmake" files in the LLVM tree that provide the interfaces for CMake's find_package() APIs, and that is probably how CoreCLR should be hooked up. If it were hooked up like that you wouldn't need to pass a command line option (unless as an override).

I don't know enough about CoreCLR, or about how the CMake package finding stuff works on Windows to know how difficult it would be to make that work.

The patch as is LGTM, but longer term I'd really like to see CoreCLR working as a CMake package.


http://reviews.llvm.org/D12679