[PATCH] D12581: [MergeFuncs] Fix callsite attributes in thunk generation

[Derek Schuff via llvm-commits]

dschuff added inline comments.

================
Comment at: lib/Transforms/IPO/MergeFunctions.cpp:1555
@@ -1554,1 +1554,3 @@
     if (CS && CS.isCallee(U)) {
+      // FIXME: This is not actually true, at least not anymore. The callsite
+      // will always have the same ABI affecting attributes as the callee,
----------------
This comment is a bit confusing as-is because it's not clear what 'This' refers to. Presumably it's the paragraph below; should this paragraph go after the first one instead?

================
Comment at: lib/Transforms/IPO/MergeFunctions.cpp:1563
@@ -1555,3 +1562,3 @@
       // Transfer the called function's attributes to the call site. Due to the
       // bitcast we will 'loose' ABI changing attributes because the 'called
       // function' is no longer a Function* but the bitcast. Code that looks up
----------------
'loose' -> lose


http://reviews.llvm.org/D12581