[PATCH] D12603: Use fixed-point representation for BranchProbability

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 09:39:06 PDT 2015


> On 2015-Sep-05, at 22:41, David Li <davidxl at google.com> wrote:
> 
> 
> ================
> Comment at: test/Analysis/BlockFrequencyInfo/basic.ll:71
> @@ -70,3 +70,3 @@
> ; The 'case_c' branch is predicted more likely via branch weight metadata.
> -; CHECK-NEXT: case_c: float = 0.8,
> +; CHECK-NEXT: case_c: float = 0.8
> case_c:
> ----------------
> where does the coma come from?

The comma was there to confirm that we get *exactly* 0.8.  Why has
that changed?

(I'm behind on this review; maybe the answer is obvious from the patch,
but it seems suspicious.  I'll try to get to this today or tomorrow.)

> 
> 
> http://reviews.llvm.org/D12603
> 
> 
> 



More information about the llvm-commits mailing list