[PATCH] D12656: Change test to allow movzbl, movzwl in place of movb, movw instructions

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 07:52:01 PDT 2015


spatel added reviewers: hfinkel, chandlerc, qcolombet.
spatel added a comment.

I'm concerned if we're adding variability where there was none before. I'm not sure if we have policy/guidelines on that, so adding some more experienced reviewers.

It would be nice to see how it's going to work at a higher level. Eg, will there be a new CPU attribute for partial register stalls that is used to trigger the different codegen? If so, can we replace the -mcpu for the test case and add a RUN line that has that attribute instead of using regex in these tests?

If this is related to PR23155, please note that here and in the commit message, so we'll have a paper trail for the motivation.


http://reviews.llvm.org/D12656





More information about the llvm-commits mailing list