[PATCH] D12665: [X86][AVX512] extend support in Scalar conversion

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: ../llvm/lib/Target/X86/X86ISelLowering.cpp:19331
@@ -19330,2 +19330,3 @@
   case X86ISD::VFPROUND:           return "X86ISD::VFPROUND";
+  case X86ISD::SFROUND:            return "X86ISD::SFROUND";
   case X86ISD::CVTDQ2PD:           return "X86ISD::CVTDQ2PD";
----------------
Please try to avoid adding new nodes. May be you can use the existing staff.

================
Comment at: ../llvm/lib/Target/X86/X86InstrAVX512.td:4494
@@ +4493,3 @@
+                            X86VectorVTInfo _DstRC, SDNode OpNode, 
+                            SDNode OpNodeRnd, Intrinsic Int>{
+let Predicates = [HasAVX512] in {
----------------
You don't use the "Int" parameter here.


http://reviews.llvm.org/D12665