[PATCH] D12317: AVX512 : vpextrb/d/q and vpinsrb/w/d/q implementation

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: lib/Target/X86/X86InstrAVX512.td:6832
@@ +6831,3 @@
+      [(set _.RC:$dst,
+          (_.VT (insertelt _.RC:$src1, (_.ScalarLdFrag addr:$src2),
+                           imm:$src3)))]>,
----------------
Please add tests for DAG lowering.

================
Comment at: lib/Target/X86/X86InstrAVX512.td:6845
@@ +6844,3 @@
+            (_.VT (insertelt _.RC:$src1,
+                             (trunc (i32 GR32:$src2)),
+                             imm:$src3)))]>, EVEX_4V;
----------------
DAG with "trunc" is not the main pattern. You should add DAG with GR16 and GR8 types.


Repository:
  rL LLVM

http://reviews.llvm.org/D12317