[patch] Fix pr24486
Maxim Ostapenko via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 7 08:55:13 PDT 2015
Hi, Rafael!
Thanks again for your patch.
> Oh, and an updated (all targets) patch is attached.
>
> On 24 August 2015 at 10:11, Rafael EspĂndola <rafael.espindola at gmail.com> wrote:
>> I just realized that this is not enough. The issues is that when using
>> the asm streamer we still have to make sure that in
>>
>> a:
>> b = a
>>
>> b is considered defined.
>>
>> It might be possible to do this in two ways:
>>
>> * Have the asm streamer use dummy fragments.
>> * Instead of saving the section or fragment of a symbol, save the base
>> symbol if any (for b it is a). Without the first change this would
>> require an extra bit in MCSymbol and I am not sure that we have it.
>>
>> I will not have the time to work on it any time soon. Maxin, can you
>> give it a try?
I've rebased your patch on top of master and tried to follow the way you
suggested about asm streamer. I've created a special DummyFragment to
mark local aliases as defined variables in MCAsmStreamer and set in
AsmPrinter::doFinalization for all variable aliases. Is that what you
meant in your suggestion? Or maybe I misunderstood you?
This patch works fine for me and passed make check on
x86_64-unknown-linux-gnu as well as simple bootstrap (I've rebuilt clang
three times by itself).
Thanks,
-Maxim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t2.diff
Type: text/x-patch
Size: 21563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150907/0163b7e5/attachment.bin>
More information about the llvm-commits
mailing list