[PATCH] D12414: [NVPTX] add an NVPTX-specific alias analysis

[hfinkel@anl.gov via llvm-commits]

hfinkel added inline comments.

================
Comment at: lib/Target/NVPTX/NVPTXAliasAnalysis.cpp:118
@@ +117,3 @@
+      auto AS2 = getAddressSpace(V2, *DL, TM);
+      if (AS1 != AS2 && AS1 != ADDRESS_SPACE_GENERIC &&
+          AS2 != ADDRESS_SPACE_GENERIC) {
----------------
I'd highly prefer we make this more future-proof and actually check here only for the address spaces the target currently understands. If you want to enable this earlier in the pipeline, there may be address spaces that are used by upper layers (garbage collection schemes, distributed memory layers, etc.), which will go away prior to hitting CodeGen, but which may not share this strict NoAlias property with those understood by the target.



http://reviews.llvm.org/D12414