[polly] r246926 - RegionGenerator: Do not modify GlobalMaps

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 5 04:26:30 PDT 2015


Author: grosser
Date: Sat Sep  5 06:26:30 2015
New Revision: 246926

URL: http://llvm.org/viewvc/llvm-project?rev=246926&view=rev
Log:
RegionGenerator: Do not modify GlobalMaps

By inspection the update of the GlobalMaps in the RegionGenerator seems unneed,
and is removed as also no test cases fail when dropping this. Johannes Doerfert
confirmed that this is indeed save:

"I think that code was needed when we did not use the scalar codegen by default.
Now everything defined in a non-affine region should be communicated via memory
and reloaded in the user block. Hence, we should be good removing this code."

Modified:
    polly/trunk/lib/CodeGen/BlockGenerators.cpp

Modified: polly/trunk/lib/CodeGen/BlockGenerators.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=246926&r1=246925&r2=246926&view=diff
==============================================================================
--- polly/trunk/lib/CodeGen/BlockGenerators.cpp (original)
+++ polly/trunk/lib/CodeGen/BlockGenerators.cpp Sat Sep  5 06:26:30 2015
@@ -1039,11 +1039,6 @@ void RegionGenerator::copyStmt(ScopStmt
     LTS[L] = SE.getUnknown(LoopPHI);
   }
 
-  // Add all mappings from the region to the global map so outside uses will use
-  // the copied instructions.
-  for (auto &BBMap : RegionMaps)
-    GlobalMap.insert(BBMap.second.begin(), BBMap.second.end());
-
   // Reset the old insert point for the build.
   Builder.SetInsertPoint(ExitBBCopy->begin());
 }




More information about the llvm-commits mailing list