[PATCH] D11856: LowerBitSets: Extend pass to support functions as bitset members.

[Peter Collingbourne via llvm-commits]

pcc added inline comments.

================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:620
@@ +619,3 @@
+          lowerBitSetCall(CI, BSI, BAI, CombinedGlobalIntAddr, GlobalLayout);
+      CI->replaceAllUsesWith(Lowered);
+      CI->eraseFromParent();
----------------
Done

================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:651
@@ +650,3 @@
+    report_fatal_error("Bit set element offset must be a constant");
+  auto OffsetInt = dyn_cast<ConstantInt>(OffsetConstMD->getValue());
+  if (!OffsetInt)
----------------
Done

================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:687
@@ +686,3 @@
+  Constant *OffsetedDisp = ConstantExpr::getSub(Disp, DispOffset);
+  OffsetedDisp = ConstantExpr::getTrunc(OffsetedDisp, Int32Ty);
+
----------------
Done


http://reviews.llvm.org/D11856