[lld] r246861 - [ELF2] Writer: Fold variables, use setVisibility(). NFCI.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 12:42:14 PDT 2015


Author: davide
Date: Fri Sep  4 14:42:14 2015
New Revision: 246861

URL: http://llvm.org/viewvc/llvm-project?rev=246861&view=rev
Log:
[ELF2] Writer: Fold variables, use setVisibility(). NFCI.

Modified:
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=246861&r1=246860&r2=246861&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Fri Sep  4 14:42:14 2015
@@ -327,12 +327,9 @@ template <class ELFT> void SymbolTableSe
       break;
     }
 
-    uint8_t Type = InputSym.getType();
-    uint8_t Binding = InputSym.getBinding();
-    ESym->setBindingAndType(Binding, Type);
+    ESym->setBindingAndType(InputSym.getBinding(), InputSym.getType());
     ESym->st_size = InputSym.st_size;
-    uint8_t Other = InputSym.st_other;
-    ESym->st_other = (Other & ~0x3) | Body->getMostConstrainingVisibility();
+    ESym->setVisibility(Body->getMostConstrainingVisibility());
     if (InputSym.isAbsolute()) {
       ESym->st_shndx = SHN_ABS;
       ESym->st_value = InputSym.st_value;




More information about the llvm-commits mailing list