[PATCH] D12590: [cmake] rework LLVM_LINK_LLVM_DYLIB option handling

[Chris Bieneman via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

Thank you for doing this. LGTM. A few comments below.


================
Comment at: cmake/modules/LLVM-Config.cmake:45
@@ -35,1 +44,3 @@
+
+  explicit_llvm_config(${executable} ${link_components})
 endmacro(llvm_config)
----------------
I do think we should strip out the components based on `LLVM_DYLIB_COMPONENTS` to make it more explicit, but this is fine, we can do that later.

================
Comment at: tools/CMakeLists.txt:35
@@ +34,3 @@
+# target is properly defined for tools that will link against it.
+add_llvm_tool_subdirectory(llvm-shlib)
+
----------------
You were correct that this isn't actually needed. Feel free to strip this out.


http://reviews.llvm.org/D12590