[PATCH] D12490: [asan] Intercept and wrap XPC callback blocks

[Alexander Potapenko via llvm-commits]

glider added a comment.

How does this test check that the underlying thread(s) has been correctly registered?
Should we make the callback crash to make sure the report is correct?


================
Comment at: lib/asan/asan_mac.cc:47
@@ -46,2 +46,3 @@
 #include <libkern/OSAtomic.h>
+#include <xpc/xpc.h>
 
----------------
While at it, can you please fix the inclusion order?

================
Comment at: test/asan/TestCases/Darwin/xpc_interceptors.mm:29
@@ +28,3 @@
+    num_frames = __asan_get_alloc_stack(mem, trace, num_frames, &thread_id);
+    fprintf(stderr, "Okay.\n", trace[0]);
+    exit(0);
----------------
Why pass trace[0] to fprintf here?


http://reviews.llvm.org/D12490