[PATCH] D11890: Fixed Visual Studio warnings.

Yaron Keren via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 04:56:23 PDT 2015


yaron.keren added inline comments.

================
Comment at: include/llvm/ADT/SmallBitVector.h:558
@@ +557,3 @@
+    if (MaskWords != 1) {
+	  assert((NumBaseBits == 64 && MaskWords == 2) && "Mask is larger than base!");
+      M |= uintptr_t(Mask[1]) << 32;
----------------
Remove the inner parenthesis. These were required in the original assert due to || but with all operators being && they are no longer needed.


================
Comment at: include/llvm/ADT/SmallBitVector.h:560
@@ +559,3 @@
+      M |= uintptr_t(Mask[1]) << 32;
+	}
+    if (InvertMask) M = ~M;
----------------
The assert is not indented while the brace too much,  clang-format the whole function. 


http://reviews.llvm.org/D11890





More information about the llvm-commits mailing list