[llvm] r246840 - [MC] Replace comparison with isUInt<32>.

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 00:22:37 PDT 2015


Author: majnemer
Date: Fri Sep  4 02:22:36 2015
New Revision: 246840

URL: http://llvm.org/viewvc/llvm-project?rev=246840&view=rev
Log:
[MC] Replace comparison with isUInt<32>.

Casting to unsigned long can cause the time to get truncated to 32-bits,
making it appear to be a valid timestamp.  Just use isUInt<32> instead.

Modified:
    llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp

Modified: llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp?rev=246840&r1=246839&r2=246840&view=diff
==============================================================================
--- llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp Fri Sep  4 02:22:36 2015
@@ -1016,7 +1016,7 @@ void WinCOFFObjectWriter::writeObject(MC
   // MS LINK expects to be able to use this timestamp to implement their
   // /INCREMENTAL feature.
   std::time_t Now = time(nullptr);
-  if (Now < 0 || (unsigned long)Now > UINT32_MAX)
+  if (Now < 0 || !isUInt<32>(Now))
     Now = UINT32_MAX;
   Header.TimeDateStamp = Now;
 




More information about the llvm-commits mailing list