[PATCH] D12604: Support: Add utility functions to get MSVC/WinSDK installation paths.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 18:03:05 PDT 2015


rnk added inline comments.

================
Comment at: lib/Support/MSVC.cpp:25
@@ +24,3 @@
+#endif
+#include <windows.h>
+
----------------
This is still an issue?

================
Comment at: lib/Support/MSVC.cpp:280
@@ +279,3 @@
+bool getVisualStudioInstallDir(std::string &Path) { return false; }
+bool getWindowsSDKDir(std::string &Path, int &X, int &Y) { return false; }
+}
----------------
You need a stub for `getWindowsSDKLibraryPath`, right?


http://reviews.llvm.org/D12604





More information about the llvm-commits mailing list