[PATCH] D12545: [elf2] Add basic archive file support.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 14:57:09 PDT 2015


+    case SymbolBody::LazyKind:
+      assert("Lazy symbols shouldn't get here.");

You want an llvm_unreachable, no? That assert never fails.

On 3 September 2015 at 17:48, Michael Spencer <bigcheesegs at gmail.com> wrote:
> Bigcheese updated this revision to Diff 33976.
> Bigcheese added a comment.
>
> Address comments.
>
>
> http://reviews.llvm.org/D12545
>
> Files:
>   ELF/Driver.cpp
>   ELF/InputFiles.cpp
>   ELF/InputFiles.h
>   ELF/SymbolTable.cpp
>   ELF/SymbolTable.h
>   ELF/Symbols.cpp
>   ELF/Symbols.h
>   ELF/Writer.cpp
>   test/elf2/archive.s
>


More information about the llvm-commits mailing list